Skip to content

Fix workspace integration failed due to the git safe.directory error #10091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Fix workspace integration failed due to the git safe.directory error #10091

wants to merge 3 commits into from

Conversation

@jenting
Copy link
Contributor

@jenting jenting commented May 18, 2022

Description

The workspace integration failed related to Git operation.
https://werft.gitpod-dev.com/job/gitpod-workspace-run-integration-tests-main.4

Recently, the Git 2.35.2 or 2.36 changes the behavior on it's stricter checks the repository ownership
https://github.blog/2022-04-18-highlights-from-git-2-36/

I think once this PR #10012 be deployed to production, we no longer need to manually configure the safe.directory manually in the code.

Related Issue(s)

Fixes #

How to test

./dev/preview/install-k3s-kubeconfig.sh
cd test

TOKEN=`kubectl get secret integration-test-user -n werft -ojsonpath={.data.token} | base64 --decode`

USER_TOKEN=$TOKEN go test -v ./... -run=TestGitActions -kubeconfig=/home/gitpod/.kube/config -namespace=default -username=integration-test-user
USER_TOKEN=$TOKEN go test -v ./... -run=TestGitHubContexts -kubeconfig=/home/gitpod/.kube/config -namespace=default -username=integration-test-user

Release Notes

None

Documentation

N/A

jenting added 3 commits May 18, 2022 06:03
@jenting
Fix running integration test not working
d3faf8e 
Run `go mod tidy` to add missing packages.

Signed-off-by: JenTing Hsiao <hsiaoairplane@gmail.com>
@jenting
Add stderr to help debug
9f55c68 
Signed-off-by: JenTing Hsiao <hsiaoairplane@gmail.com>
@jenting
Git config safe.directory
920b1ce 
Signed-off-by: JenTing Hsiao <hsiaoairplane@gmail.com>
@jenting
Copy link
Contributor Author

jenting commented May 18, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-jenting-fix-go-test-not-working.1
(with .werft/ from main)

@jenting
Copy link
Contributor Author

jenting commented May 18, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run clean-slate-deployment

👍 started the job as gitpod-build-jenting-fix-go-test-not-working.2
(with .werft/ from main)

@jenting jenting closed this May 18, 2022
@jenting jenting deleted the jenting/fix-go-test-not-working branch May 18, 2022 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

release-note-none size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jenting @roboquat